From cfaa773cf74aeddea0ad94537a06f25480e04b34 Mon Sep 17 00:00:00 2001 From: Si Date: Sat, 26 Sep 2026 20:49:10 +0200 Subject: [PATCH] Give the video effects more room in the Add effect menu With eight video effects their list filled its 110-pixel cap, and the menu's headings take more than the 120 pixels the height test allowed for them. Co-Authored-By: Claude Opus 5.5 --- CHANGELOG.md | 2 ++ src/gui/window.cpp | 4 ++-- tests/gui_tests.cpp | 4 +++- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index bda4a7f..963393a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -59,6 +59,8 @@ commit that made it. The interface shows this file under Changelog in its menu. - Save opens in the project's folder, and after the first save it offers the last saved file's name with a number counted on (`city.png`, then `city-1.png`, `city-2.png`), skipping names already taken. +- The Add effect menu gives the video effects more room before their list + scrolls, now that there are more of them. ## [0.7.0] - 2026-09-26 diff --git a/src/gui/window.cpp b/src/gui/window.cpp index 68f68e8..a10bb76 100644 --- a/src/gui/window.cpp +++ b/src/gui/window.cpp @@ -1779,8 +1779,8 @@ Gtk::Widget& EffectorWindow::buildChainSection() { // The tallest each part of the menu of effects grows before it scrolls, in // pixels: together, with their headings, short enough to open below a button // near the top of a small screen. -constexpr int addMenuImageHeight = 330; -constexpr int addMenuVideoHeight = 110; +constexpr int addMenuImageHeight = 300; +constexpr int addMenuVideoHeight = 150; // One entry per registered effect, so a new effect shows up here without this // file knowing anything about it. The image effects and the video effects diff --git a/tests/gui_tests.cpp b/tests/gui_tests.cpp index fbcb951..e6976b5 100644 --- a/tests/gui_tests.cpp +++ b/tests/gui_tests.cpp @@ -242,7 +242,9 @@ void runTests(Gtk::Window& window) { } check(scrolled, "the image and the video entries scroll, each on their own"); check(cap > 0 && cap <= 480, "past a height that fits a small screen"); - check(menu->get_height() > 0 && menu->get_height() <= cap + 120, + // The rest is the two headings, the separator and, in a still, the hint + // under the video heading. + check(menu->get_height() > 0 && menu->get_height() <= cap + 170, "and the menu stays within it however many effects there are"); add->popdown(); pump();